Skip to content

Conversation

@apostasie
Copy link
Contributor

incu6us/goimports-reviser#157 (comment) got fixed upstream

This PR removes our hack workaround, which is no longer necessary.

@apostasie apostasie marked this pull request as ready for review February 22, 2025 04:24
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.x.x (tentative) milestone Feb 22, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 22, 2025
@apostasie
Copy link
Contributor Author

Latest CI failures are #3908 and (likely) #3556

@apostasie
Copy link
Contributor Author

apostasie commented Feb 22, 2025

Given the prevalence of #3908 which is basically hitting every PR we might want to revert the changes in the test (or better, fix it). #3918 should fix

@apostasie apostasie changed the title goimports-reviser: remove hack CI: goimports-reviser: remove hack Feb 23, 2025
@apostasie
Copy link
Contributor Author

Rebased.

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Contributor Author

Rebased - hopefully the CI drama is acceptable with the extended timeouts now.

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 5f11371 into containerd:main Feb 26, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci e.g., CI failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants