Skip to content

CI: remove unbuffer from container tests #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2025
Merged

CI: remove unbuffer from container tests #3919

merged 1 commit into from
Feb 24, 2025

Conversation

@apostasie
Copy link
Contributor

@apostasie apostasie commented Feb 24, 2025

This PR rewrites a pair of container tests that were previously using unbuffer, using the new WithPseudoTTY test tooling facility.

@apostasie
Remove unbuffer from container tests
655171c 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Feb 24, 2025

This should be removed too?

nerdctl/Dockerfile

Line 279 in 46be3a7

# `expect` package contains `unbuffer(1)`, which is used for emulating TTY for testing

@apostasie
Copy link
Contributor Author

apostasie commented Feb 24, 2025 •
edited
Loading

This should be removed too?

nerdctl/Dockerfile

Line 279 in 46be3a7

# `expect` package contains `unbuffer(1)`, which is used for emulating TTY for testing

Soon. We still have unbuffer in compose tests for now.

@AkihiroSuda AkihiroSuda added this to the v2.x.x (tentative) milestone Feb 24, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Feb 24, 2025
AkihiroSuda
AkihiroSuda approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 1d4cdfa into containerd:main Feb 24, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci e.g., CI failure

Projects

None yet

Milestone

v2.0.4

Development

Successfully merging this pull request may close these issues.

2 participants

@apostasie @AkihiroSuda