fix:forbid to restart/start container created by k8s #4516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningmingxiao
force-pushed
the
forbid_restart_k8s
branch
from
0a432e1 to
bba4942
Compare
ningmingxiao
changed the title
AkihiroSuda
reviewed
Sep 17, 2025
pkg/cmd/container/restart.go
Outdated
| return fmt.Errorf("can't get container %s info ", found.Container.ID()) | ||
| } | ||
| if _, ok := info.Labels[k8slabels.ContainerType]; ok { | ||
| return fmt.Errorf("can't restart container %s created by k8s", info.ID) |
Member
There was a problem hiding this comment.
Printing a warning may suffice
ningmingxiao
force-pushed
the
forbid_restart_k8s
branch
from
bba4942 to
b1051da
Compare
AkihiroSuda
reviewed
Sep 17, 2025
AkihiroSuda
reviewed
Sep 17, 2025
pkg/cmd/container/restart.go
Outdated
| } | ||
| if _, ok := info.Labels[k8slabels.ContainerType]; ok { | ||
| log.L.Warnf("can't restart container %s created by k8s", info.ID) | ||
| return nil |
Member
There was a problem hiding this comment.
Suggested change
| return nil |
Contributor
Author
There was a problem hiding this comment.
if remove return nerdctl will try to restart container created by k8s @AkihiroSuda
Member
There was a problem hiding this comment.
Yes, and the user will learn that it is an unsupported operation.
AkihiroSuda
reviewed
Sep 17, 2025
ningmingxiao
force-pushed
the
forbid_restart_k8s
branch
3 times, most recently
from
790f239 to
f3b8f14
Compare
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao
force-pushed
the
forbid_restart_k8s
branch
from
f3b8f14 to
2e888f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some people want to use nerdctl to restart container created by k8s, It is necessary to return an error to forbid user start/restart the container.
ping @AkihiroSuda @djdongjin Thanks