Skip to content

Conversation

@TomSweeneyRedHat
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat commented Jul 16, 2025

Possible replacement for #2476. I'm not sure if I messed something up when trying to merge in #2478 there, so I thought I'd create this PR to see if I messed something up there when doing the merge/vendor.

If this passes the lint tests, I'll add the common bumps, and I'll kill #2476

Summary by Sourcery

Upgrade primary and indirect Go dependencies to the latest compatible versions

Enhancements:

  • Bump github.com/containers/image/v5 to v5.36.0
  • Bump github.com/containers/storage to v1.59.0
  • Update various indirect modules (e.g., mergo, hcsshim, docker/docker, go-logr, sqlite3, sigstore, opentelemetry, grpc) to newer versions

Build:

  • Regenerate go.mod and go.sum to reflect updated dependency versions

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 16, 2025

Reviewer's Guide

Upgrade primary container modules (containers/image and containers/storage) to the latest releases and sync all indirect dependencies via go mod tidy, updating go.sum accordingly.

File-Level Changes

Change Details Files
Bump primary dependencies versions
  • containers/image v5.35.0 → v5.36.0
  • containers/storage v1.58.0 → v1.59.0
go.mod
Refresh indirect modules and checksums
  • Upgrade various indirect modules (mergo, hcsshim, docker, logr, sqlite3, sigstore, go-patricia, mpb, OpenTelemetry, gRPC)
  • Run go mod tidy and regenerate go.sum
go.mod
go.sum

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TomSweeneyRedHat - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sourcery-ai[bot], TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/0.64.0_try2 branch 3 times, most recently from 7e00216 to 7aa32e5 Compare July 17, 2025 00:10
Possible replacement for containers#2476.  I'm not sure if I messed
something up when trying to merge in containers#2478 there, so thought I'd create
this PR to see if I messed something up there when doing the
merge/vendor.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat TomSweeneyRedHat force-pushed the dev/tsweeney/0.64.0_try2 branch from 7aa32e5 to 5e7264f Compare July 17, 2025 00:16
Bump c/common to v0.64.0 in preparation for Podman v5.6

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Bump to the next dev version, 0.65.0-dev, in the main c/common
branch.

Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
@TomSweeneyRedHat
Copy link
Member Author

Don't merge! I was working on a few small lint errors when the prior PR was closed. I'll create a new PR to fix those up.

@TomSweeneyRedHat
Copy link
Member Author

Closing. Versions and lint issues will be taken care of elsewhere.

@TomSweeneyRedHat TomSweeneyRedHat deleted the dev/tsweeney/0.64.0_try2 branch July 17, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant