unshare: add getenv from cgo #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if CGO is enabled, make sure to use C.getenv instead of os.Getenv to read environment variables. It is required since rootless libpod joins the user namespace through Cgo. The variables set via C.setenv are not visible through os.Getenv, as the latter uses sync.Once to read the variables once. Requires: containers/podman#4911 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
|
LGTM |
M1cha
pushed a commit
to M1cha/common
that referenced
this pull request
Dec 20, 2022
Set sysctl net.ipv4.ip_forwarding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if CGO is enabled, make sure to use C.getenv instead of os.Getenv to
read environment variables. It is required since rootless libpod
joins the user namespace through Cgo.
The variables set via C.setenv are not visible through os.Getenv, as
the latter uses sync.Once to read the variables once.
Requires: containers/podman#4911
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com