tree: Add module-level docs #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeckersb
approved these changes
Oct 2, 2025
Assisted-by: Claude Code Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
added a commit
to cgwalters/composefs-rs
that referenced
this pull request
Oct 18, 2025
The previous change to use 'create-image --bootable --stat-root' was incorrect. The working version (PR containers#186) used 'compute-id --bootable'. Revert to the working approach. Signed-off-by: Claude <noreply@anthropic.com>
cgwalters
added a commit
to cgwalters/composefs-rs
that referenced
this pull request
Oct 18, 2025
The changes to use stdout=PIPE and communicate() in testthing.py caused the QEMU process to block until exit, preventing SSH connections from being established during VM runtime. Revert to the original working version from PR containers#186 that uses wait() instead of communicate(). Signed-off-by: Claude <noreply@anthropic.com>
cgwalters
added a commit
to cgwalters/composefs-rs
that referenced
this pull request
Oct 21, 2025
The previous change to use 'create-image --bootable --stat-root' was incorrect. The working version (PR containers#186) used 'compute-id --bootable'. Revert to the working approach. Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
added a commit
to cgwalters/composefs-rs
that referenced
this pull request
Oct 21, 2025
The changes to use stdout=PIPE and communicate() in testthing.py caused the QEMU process to block until exit, preventing SSH connections from being established during VM runtime. Revert to the original working version from PR containers#186 that uses wait() instead of communicate(). Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Colin Walters <walters@verbum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at something here and felt it could use some docs, so decided to work on that.
Assisted-by: Claude Code