mount: Consistently use composefs as source#303
Merged
giuseppe merged 1 commit intocomposefs:mainfrom Jul 18, 2024
Merged
Conversation
The "source" field for overlayfs isn't strictly meaningful, by default; but it's useful to identify at least the software that created the mount. Motivated by https://gitlab.com/redhat/centos-stream/containers/bootc/-/issues/301 where some QE testing noticed that an updated composefs using the new mount API didn't specify the source at all, so it ends up as `none`, but if we fall back to the legacy one it uses `overlayfs`. Change both to be `composefs`. Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "source" field for overlayfs isn't strictly meaningful, by default; but it's useful to identify at least the software that created the mount.
Motivated by https://gitlab.com/redhat/centos-stream/containers/bootc/-/issues/301 where some QE testing noticed that an updated composefs using the new mount API didn't specify the source at all, so it ends up as
none, but if we fall back to the legacy one it usesoverlayfs.Change both to be
composefs.