Verify payload length early on#310
Merged
alexlarsson merged 1 commit intocomposefs:mainfrom Aug 5, 2024
Merged
Conversation
cgwalters
force-pushed
the
symlink-limit
branch
2 times, most recently
from
5e73d35 to
58081f6
Compare
I was looking at something else here and happened to notce we didn't seem to be sanity checking the length of strings in some places. Looking harder, first thing I checked is a really long filename in a dump file; that's fine, we do check that. Next I tried symlinks, and that caused a an assertion trip process abort (thankfully at least) deep in the bowels of the EROFS generation. Fix this by checking the payload length against PATH_MAX. Also: - Add the missing error checking in mkcomposefs - Add test infrastructure for "should fail" dumpfiles Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
symlink-limit
branch
from
58081f6 to
b06ea9b
Compare
alexlarsson
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking at something else here and happened
to notce we didn't seem to be sanity
checking the length of strings in some places.
Looking harder, first thing I checked is a
really long filename in a dump file; that's
fine, we do check that.
Next I tried symlinks, and that caused a
an assertion trip process abort (thankfully at least) deep in the bowels of the EROFS generation.
Fix this by checking the payload length against PATH_MAX.
Also: