lib: Bail on xattr names > XATTR_NAME_MAX#314
Merged
alexlarsson merged 2 commits intocomposefs:mainfrom Aug 19, 2024
Merged
Conversation
- We were missing a meson invocation; add it - Pass the locally built binary path - Add an output file (oops) - Don't `cd` to the test dir since that breaks the relative path to the input file Signed-off-by: Colin Walters <walters@verbum.org>
Just more of me poking randomly at mkcomposefs. Yes, we clearly need to wire up a fuzzer. In this case, we have a check for xattr value length but would happily accept a key of any arbitrary length, generating a corrupted EROFS blob. `fsck.erofs` detects this. Signed-off-by: Colin Walters <walters@verbum.org>
Merged
alexlarsson
approved these changes
Aug 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just more of me poking randomly at mkcomposefs. Yes, we clearly
need to wire up a fuzzer.
In this case, we have a check for xattr value length but would
happily accept a key of any arbitrary length, generating
a corrupted EROFS blob.
fsck.erofsdetects this.Signed-off-by: Colin Walters walters@verbum.org