Merged
Conversation
cgwalters
added a commit
to cgwalters/composefs
that referenced
this pull request
Sep 4, 2024
Pairs with composefs#329 which adapts the C side to properly accept these too. This breaks semver, we'll need to bump that. Signed-off-by: Colin Walters <walters@verbum.org>
Contributor
Author
But if any callers had been interacting with this via |
I stumbled across the fact that on Linux/glibc at least `dev_t` is 64 bits, but we were truncating it to 32 bits. Note that the type used in the `mkcomposefs` binary was already uint64_t but because C happily truncates/converts integers this was missed. Signed-off-by: Colin Walters <walters@verbum.org>
allisonkarlitskaya
pushed a commit
to composefs/composefs-rs
that referenced
this pull request
Nov 7, 2024
Pairs with composefs/composefs#329 which adapts the C side to properly accept these too. This breaks semver, we'll need to bump that. Signed-off-by: Colin Walters <walters@verbum.org>
allisonkarlitskaya
pushed a commit
to composefs/composefs-rs
that referenced
this pull request
Nov 7, 2024
Pairs with composefs/composefs#329 which adapts the C side to properly accept these too. This breaks semver, we'll need to bump that. Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled across the fact that on Linux/glibc at least
dev_tis 64 bits, but we were truncating it to 32 bits.Note that the type used in the
mkcomposefsbinary was already uint64_t but because C happily truncates/converts integers this was missed.