rust: Accept 64 bit values for rdev#330
Merged
cgwalters merged 1 commit intocomposefs:mainfrom Sep 6, 2024
Merged
Conversation
Pairs with composefs#329 which adapts the C side to properly accept these too. This breaks semver, we'll need to bump that. Signed-off-by: Colin Walters <walters@verbum.org>
jeckersb
approved these changes
Sep 5, 2024
Collaborator
There was a problem hiding this comment.
👍
It somehow never occurred to me that the fields on a struct-style enum variant are implicitly public. There's an RFC to allow them to be private though, and the discussion contains some tricks to achieve opaqueness using the current system. Just thought I'd mention it here in case we'd really rather hide all of the internal details of Item and only expose it through accessor methods and/or via Display.
Contributor
Author
|
Even if the struct data wasn't public presumably we would have made a public getter be That said making the fields not be public we could make invalid states not be constructable though which is probably a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pairs with #329 which adapts the C side to properly accept these too.
This breaks semver, we'll need to bump that.