mkcomposefs: Process last content in dumpfile without newline#331
Merged
jeckersb merged 1 commit intocomposefs:mainfrom Sep 6, 2024
Merged
mkcomposefs: Process last content in dumpfile without newline#331jeckersb merged 1 commit intocomposefs:mainfrom
jeckersb merged 1 commit intocomposefs:mainfrom
Conversation
cgwalters
force-pushed
the
reject-no-trailing-newline
branch
from
90c1f83 to
ce3373f
Compare
cgwalters
changed the title
cgwalters
force-pushed
the
reject-no-trailing-newline
branch
from
ce3373f to
202821a
Compare
I was doing some more testing and ended up crafting a dumpfile without a trailing newline. It took me a surprising amount of time to figure out that we just ignore data without a trailing newline. Hopefully, this doesn't break anyone. Closes: composefs#327 Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
reject-no-trailing-newline
branch
from
202821a to
ad20026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was doing some more testing and ended up crafting a dumpfile
without a trailing newline. It took me a surprising amount
of time to figure out that we just ignore data without a
trailing newline.
Hopefully, this doesn't break anyone.
Closes: #327
Signed-off-by: Colin Walters walters@verbum.org