libcomposefs: detect short erofs files#333
Merged
cgwalters merged 1 commit intocomposefs:mainfrom Sep 6, 2024
Merged
Conversation
When attempting to read the header of the erofs file before mounting it, we verify that the read is successful, but not that the full header has been returned. We then proceed to access the header, which means we could be reading uninitialized memory. Add a check to verify that we've read the full header. If not, return -EINVAL, which is what we already return in case the header was incorrect. Signed-off-by: Allison Karlitskaya <allison.karlitskaya@redhat.com>
cgwalters
approved these changes
Sep 6, 2024
Contributor
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
ooo 🙈 Nice find!
I wonder if this one might also be related to https://github.com/containers/storage/issues/2042
Contributor
|
Hello @allisonkarlitskaya there's a request to relicense this repository, please comment on #344 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to read the header of the erofs file before mounting it, we verify that the read is successful, but not that the full header has been returned. We then proceed to access the header, which means we could be reading uninitialized memory.
Add a check to verify that we've read the full header. If not, return -EINVAL, which is what we already return in case the header was incorrect.