tests: Move sha verification after other checks#338
Merged
jeckersb merged 1 commit intocomposefs:mainfrom Sep 10, 2024
Merged
Conversation
When testing out changes to a dumpfile, today the sha check will always fail first if I don't go and change the expected value, but most of the time what I want to know is whether or not it passes the *other* tests at least. Move the checksum verification last, and also while we're here print an "ok" value. Signed-off-by: Colin Walters <walters@verbum.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When testing out changes to a dumpfile, today the sha check will always fail first if I don't go and change the expected value, but most of the time what I want to know is whether or not it passes the other tests at least.
Move the checksum verification last, and also while we're here print an "ok" value.