writer: Clarifications around our usage of EROFS_NULL_ADDR#345
Merged
alexlarsson merged 1 commit intocomposefs:mainfrom Sep 16, 2024
Merged
writer: Clarifications around our usage of EROFS_NULL_ADDR#345alexlarsson merged 1 commit intocomposefs:mainfrom
alexlarsson merged 1 commit intocomposefs:mainfrom
Conversation
- Followup from review comments to clarify how this works - Rename the function to further reinforce it's not "empty" it's actually the special null addr - Actually use the `EROFS_NULL_ADDR` constant when we do the writing to make the connection more obvious - When reading back an erofs, at least verify that it's chunk based as extra validation. Signed-off-by: Colin Walters <walters@verbum.org>
hsiangkao
reviewed
Sep 14, 2024
| static int write_empty_chunks(struct lcfs_ctx_s *ctx, uint32_t chunk_count) | ||
| // Each chunk pointer appears as if it's filled with zeros using the dedicated | ||
| // EROFS_NULL_ADDR. | ||
| static int write_nullptr_chunks(struct lcfs_ctx_s *ctx, uint32_t chunk_count) |
Contributor
There was a problem hiding this comment.
although we usually call it as holes ;)
alexlarsson
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EROFS_NULL_ADDRconstant when we do the writing to make the connection more obvious