mkcomposefs: make it cpuset aware#355
Merged
cgwalters merged 1 commit intocomposefs:mainfrom Sep 20, 2024
Merged
Conversation
use sched_getaffinity to get the CPUs that can be used. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
cgwalters
approved these changes
Sep 20, 2024
Contributor
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Looks sane to me. One thing I just did was a quick code search and yeah that led to the exact same code in swift.
That said I think an even nicer thing for us to consider in the future is support for the GNU make jobserver protocol which gives us a way to integrate with other build systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny improvement that I've noticed while looking at the code.
use sched_getaffinity to get the CPUs that can be used.