Merged
Conversation
alexlarsson
reviewed
Sep 30, 2024
I came across the fact that we had two copy-paste implementations of converting a binary digest to hex. Deduplicate with an internal shared library. NOTE: I don't speak meson fluently so please check if I messed something up there. Signed-off-by: Colin Walters <walters@verbum.org>
This function is a bit too big to be an inline, so move it to our new impl file where it's nicely next to its inverse. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
dedup-hex
branch
from
f8c5a40 to
93e9d17
Compare
alexlarsson
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across the fact that we had two copy-paste implementations
of converting a binary digest to hex.
Deduplicate with an internal shared library.
NOTE: I don't speak meson fluently so please check if I messed
something up there.