Skip to content

Add a CONTRIBUTING.md#381

Merged
cgwalters merged 1 commit intocomposefs:mainfrom
cgwalters:add-contributing
Oct 25, 2024
Merged

Add a CONTRIBUTING.md#381
cgwalters merged 1 commit intocomposefs:mainfrom
cgwalters:add-contributing

Conversation

@cgwalters
Copy link
Copy Markdown
Contributor

Motivated by improving our project standards.

Copy link
Copy Markdown
Collaborator

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe
Copy link
Copy Markdown
Collaborator

used this PR as a base for containers/crun#1590

Motivated by improving our project standards.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters cgwalters merged commit 0cb1f05 into composefs:main Oct 25, 2024
@eriksjolund
Copy link
Copy Markdown
Collaborator

Sidenote regarding the line

https://github.com/containers/composefs/blob/0cb1f05a9fdc6a00a2628ed931d0c80f801e22ac/CONTRIBUTING.md?plain=1#L128

No previous commits fulfil the requirement

$ git clone -q https://github.com/containers/composefs.git
$ git -C composefs log | grep 'Closes: #' | wc -l
       0

(I'm fine with the change. I just wanted to mention this fact)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants