Skip to content

Fix conmon exec exit status handling#584

Merged
jnovy merged 1 commit intocontainers:mainfrom
jnovy:328
Sep 2, 2025
Merged

Fix conmon exec exit status handling#584
jnovy merged 1 commit intocontainers:mainfrom
jnovy:328

Conversation

@jnovy
Copy link
Collaborator

@jnovy jnovy commented Sep 2, 2025

For exec operations, use runtime exit status instead of container status and skip runtime failure check since non-zero exit is expected behavior.

The fix addresses two core issues:

  • early exit when runtime returns non-zero (treating exec failures as runtime failures)
  • using container_status instead of runtime_status for final exit code determination

Fixes #328

For exec operations, use runtime exit status instead of container status
and skip runtime failure check since non-zero exit is expected behavior.

The fix addresses two core issues:
- early exit when runtime returns non-zero (treating exec failures as runtime failures)
- using container_status instead of runtime_status for final exit code determination

Fixes containers#328

Signed-off-by: Jindrich Novy <jnovy@redhat.com>
@jnovy jnovy requested a review from giuseppe September 2, 2025 16:40
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jnovy jnovy merged commit 540c545 into containers:main Sep 2, 2025
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

conmon exec not handling runtime failures

2 participants