Fix conmon exec exit status handling#584
Merged
jnovy merged 1 commit intocontainers:mainfrom Sep 2, 2025
Merged
Conversation
For exec operations, use runtime exit status instead of container status and skip runtime failure check since non-zero exit is expected behavior. The fix addresses two core issues: - early exit when runtime returns non-zero (treating exec failures as runtime failures) - using container_status instead of runtime_status for final exit code determination Fixes containers#328 Signed-off-by: Jindrich Novy <jnovy@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For exec operations, use runtime exit status instead of container status and skip runtime failure check since non-zero exit is expected behavior.
The fix addresses two core issues:
Fixes #328