Merged
Conversation
Member
Author
4b735b4 to
c7d5d5e
Compare
Member
Author
|
@jnovy , this is ready for review now. |
c9702cd to
cf7a9c0
Compare
jnovy
requested changes
Sep 26, 2025
cf7a9c0 to
feacd99
Compare
jnovy
reviewed
Sep 30, 2025
jnovy
requested changes
Sep 30, 2025
| test_resize_command_ok "1 65535 65535" "24 80" | ||
| } | ||
|
|
||
| @test "ctrl: rotate logs with --log-rotate" { |
Collaborator
There was a problem hiding this comment.
Could you remove:
@test "ctrl: rotate logs" {
start_conmon_with_default_args --log-path "k8s-file:$LOG_PATH" -t
wait_for_runtime_status "$CTR_ID" running
# Remove the log.
rm -f $LOG_PATH
# The control message should reopen/recreate it.
echo "2 1 1" > ${CTL_PATH}
start_conmon_with_default_args \
--log-path "k8s-file:$LOG_PATH.exec" \
--exec \
--exec-process-spec "${BUNDLE_PATH}/process.json"
wait_for_runtime_status "$CTR_ID" stopped
# Check that the log exists now.
assert_file_exists "$LOG_PATH"
run cat "$LOG_PATH"
# No terminal resize
assert "${output}" =~ "standard input"
}
As you r new test tests the same thing more throughly?
Member
Author
There was a problem hiding this comment.
This test actually tests that you can rotate logs using the control message. This is different scenario than the ones in the 03-k8s-log-rotation.bats.
This commit adds tests for: - the `--log-label` option. - the `--log-tag` option. - the partial message in both journald and k8s-file. - the log rotation using the `ctl` command. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
feacd99 to
718d3ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds tests for:
--log-labeloption.--log-tagoption.ctlcommand.