Skip test if RUNTIME_BINARY is not runc#628
Merged
jnovy merged 1 commit intocontainers:mainfrom Feb 3, 2026
Merged
Conversation
jnovy
requested changes
Feb 3, 2026
test/04-runtime.bats
Outdated
| @@ -93,6 +93,9 @@ teardown() { | |||
| } | |||
|
|
|||
| @test "runtime: runtime error with _OCI_SYNCPIPE defined" { | |||
Collaborator
There was a problem hiding this comment.
Maybe let's state this also in the test description?
runtime: runc error with _OCI_SYNCPIPE defined
test/04-runtime.bats
Outdated
| } | ||
|
|
||
| @test "runtime: runtime error with _OCI_SYNCPIPE defined" { | ||
| if ! [[ $RUNTIME_BINARY =~ runc ]]; then |
Collaborator
There was a problem hiding this comment.
Suggest:
[[ $(basename "$RUNTIME_BINARY") == "runc" ]]
to avoid false positives as it matches anything containing runc?
Contributor
Author
There was a problem hiding this comment.
Fixed. I think you meant [[ $(basename "$RUNTIME_BINARY") != "runc" ]]
Also rename the test to reflect the fact that it uses runc Signed-off-by: Ricardo Branco <rbranco@suse.de>
ef95cee to
3bb1a4e
Compare
Collaborator
|
Merged, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip test if RUNTIME_BINARY is not runc.
We run these tests also with crun and this one was designed for runc and fails with:
https://openqa-assets.opensuse.org/tests/5644472/file/conmon-conmon-runc-user.tap.txt