cirrus: some fixes #28
Conversation
First a change in .cirrus.yml must run all tests we cannot skip them as we might chnage what tasks are being executed and how, i.e. an CI image update must always run all tests. Second use only_if and not skip, skip will bloat the task overview with plenty of tasks so it is harder to see what was actully run then. that is consistent with how we do it in podman. And drop the vendor task as we do not do vendor anymore. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Also drop the vendor step, we don't need that anymore. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
And update the CIRRUS_WORKING_DIR to use the proper repo path. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
To speed up tests. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
Looks plausible otherwise — I didn’t review the test logs, though.
| skip: "!changesInclude('storage/**', 'image/**')" | ||
| # The git-validation tool doesn't work well on branch or tag push, | ||
| # under Cirrus-CI, due to challenges obtaining the starting commit ID. | ||
| # Only do validation for PRs. |
There was a problem hiding this comment.
Was dropping this extra condition intentional?
There was a problem hiding this comment.
For now yes, I was to lazy to make custom conditions here because I though this job and the storage/common validation should all be merged together. Because well validating the commits here isn't a image specific thing so my next step is to consolidate the validate/lint jobs into one thus for now I think it is fine to leave it like that
There was a problem hiding this comment.
*shrug* fine. I’m all for consolidating / improving the CI scripting, and it’s not very clear what this is warning about. I guess we’ll find out :) The way I read it, we should still be able to merge PRs on stable branches, so we won’t be scrambling to do a backport.
|
/LGTM |
4 participants
First a change in .cirrus.yml must run all tests we cannot skip them as we might chnage what tasks are being executed and how, i.e. an CI image update must always run all tests.
Second use only_if and not skip, skip will bloat the task overview with plenty of tasks so it is harder to see what was actully run then. that is consitent with how we do it in podman.