Image repo references #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
approved these changes
Aug 26, 2025
| cat <<EOF | ||
| DESTDIR="/var/tmp/go/src/github.com/containers/image" | ||
| UPSTREAM_REPO="https://github.com/containers/image.git" | ||
| UPSTREAM_REPO="https://github.com/containers/container-libs.git" |
Member
There was a problem hiding this comment.
That is most likely not enough but I guess it won't do any harm either so that is fine
Contributor
Author
There was a problem hiding this comment.
Yes, https://github.com/containers/automation_images/blob/a0b436c1239299ebecc4fad849ec3961f305ff98/get_ci_vm/README.md suggests this requires a specific repo layout, where moving everything inside image/ doesn’t transparently work.
(I don’t think I have ever run this script…)
Member
There was a problem hiding this comment.
I use this regularly (on podman that is) but yeah once all the other CI stuff is done I can look at this, it is an optional thing so not really a priority
Member
|
LGTM |
Member
|
@mtrmac , can you rebase please? This should fix the tests. |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Fetch from the right repo, otherwise this is not going to find a recent parent commit, and the check is going to take a very long time. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Just assume module use, nowadays. (Also, drops a link to the old c/image repo location.) Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Untested! Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
image-repo-references
branch
from
6c8c326 to
2857b60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update references to
github.com/containers/imagewhere relevant.Note that I didn’t update the reference in
internal/useragent.DefaultUserAgent, that’s an ABI of sorts (well… if anything is checking for that at all.)