Skip to content

Conversation

@manusa
Copy link
Member

@manusa manusa commented Nov 17, 2025

Follows-up on #425

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa added this to the 0.1.0 milestone Nov 17, 2025
@manusa manusa requested review from Cali0707 and matzew November 17, 2025 11:11
README.md Outdated
Comment on lines 211 to 216
| Toolset | Description |
|---------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| config | View and manage the current local Kubernetes configuration (kubeconfig) |
| core | Most common tools for Kubernetes management (Pods, Generic Resources, Events, etc.) |
| helm | Tools for managing Helm charts and releases |
| kiali | Most common tools for managing Kiali, check the [Kiali integration documentation](https://github.com/containers/kubernetes-mcp-server/blob/main/docs/KIALI_INTEGRATION.md) for more details. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manusa can we add a column to this table about enabled/disabled by default?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment this is summarized in line 207 (managed manually).
By next version, I think we'll only enable core and config by default.
Do you still think it makes sense to add the column? (i.e. at some point there might be 10 rows and only two of them will have the check)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I get your point

My thinking was that it can be clearer to understand what is enabled while looking at the table (that has the descriptions), than going between the comment above and the table.

Maybe we can add to the descriptions for the enabled by default toolsets "Enabled by default" ? That way there's no extra column but it's also easy to tell what is enabled just from the table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try different alternatives and see what looks better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I let Claude work freely on this one. It seems it did a good job, please recheck

Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa requested a review from Cali0707 November 17, 2025 14:35
Copy link
Collaborator

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks great @manusa !

@Cali0707 Cali0707 merged commit 0e88935 into containers:main Nov 17, 2025
6 checks passed
@manusa manusa deleted the chore/readme branch November 17, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants