Skip to content

Conversation

@Cali0707
Copy link
Collaborator

To make it easier for people adding toolsets to complete arbitrary actions against arbitrary resources while maintaining the access control, this creates a rest.Interface that is configured with a roundtripper that will ensure that only requests against GVRs that are allowed can be made.

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707
Copy link
Collaborator Author

@manusa not totally sure if we want this or not, just trying to prototype some ways to make it easier for toolset authors to do what they want while enforcing the access control. Lmk what you think!

@manusa
Copy link
Member

manusa commented Nov 18, 2025

This is exactly the approach I wanted to follow: Move it up the stack as much as possible so that we don't need to check for access at the specific clients.
If all clients are using the RoundTripper or the approved REST Client, then we should be safe.

What I'm not sure is about the side-effects of this approach, neither if there are edge cases that need further consideratio.

Let me work on the base you created here and see if we can actually free ourselves from the other client implementations and fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants