feat(config)!: consolidate custom config parsing into config.Extended #475
+238
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Cali0707
reviewed
Nov 18, 2025
|
|
||
| // Extended is the interface that all configuration extensions must implement. | ||
| // Each extended config manager registers a factory function to parse its config from TOML primitives | ||
| type Extended interface { |
Collaborator
There was a problem hiding this comment.
nit: I feel like ExtendedConfig is a bit clearer here
Suggested change
| type Extended interface { | |
| type ExtendedConfig interface { |
Member
Author
There was a problem hiding this comment.
ExtendedConfig is explicitly marked as problematic (redundant) by some linters since it contains the package name, you'd usually refer to this as config.Extended
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Member
Author
|
Hi @Cali0707 Addressed the comments regarding ExtendedConfigRegistry and making it private. I didn't change #475 (comment) yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
This might imply breaking changes downstream if there are references to the interfaces.
I think the breaking changes tradeoff is OK because there is now a single simple config.Extended interface which avoids code duplication.
This will also allow to better reuse the pattern for other config extensions if needed.