Skip to content

Conversation

@peppergrayxyz
Copy link

fixes #433

@mtjhrc
Copy link
Collaborator

mtjhrc commented Oct 21, 2025

Thanks for contributing here. Please sign-off the commits in your PRs (git commit --signoff).

@mtjhrc
Copy link
Collaborator

mtjhrc commented Oct 21, 2025

The DCO CI check is still failing because:

Commit sha: 2face26, Author: Pepper Gray, Committer: Pepper Gray; Expected "Pepper Gray 111446242+peppergrayxyz@users.noreply.github.com", but got "Pepper Gray hello@peppergray.xyz".

You need to make the author of the commit match the Signed-off-by - I think this is a setting in GitHub, where it uses their generated noreply email address.

Makefile Outdated
endif

OS = $(shell uname -s)
CC?= gcc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really work, by default CC will be cc (at least on GNU Make) which means this assignment will never happen.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the line!

fix: containers#433
Signed-off-by: Pepper Gray <hello@peppergray.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make: gcc: No such file or directory

2 participants