-
Notifications
You must be signed in to change notification settings - Fork 549
Hide stack trace shown on YAML parse error by default #1253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9830e4a to
a2709e9
Compare
|
|
||
|
|
||
| def bad_compose_yaml_path() -> str: | ||
| """ "Returns the path to the bad compose file""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obvious comment -> remove
|
|
||
|
|
||
| def good_compose_yaml_path() -> str: | ||
| """ "Returns the path to the good compose file""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obvious comment -> remove
I think this is historical artifact. I would prefer consistent use of log.fatal()
I think using sys.exit() is bad practice. If you want to spend time on fixing this, let's do it in another PR. |
p12tic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, also please add a newsfragment.
Fixes containers#1139 Signed-off-by: Yusuke Matsubara <whym@whym.org>
|
Rebased and squashed related commits. |
A YAML parse error is not caused by the podman-compose code, and the stack trace will not be helpful
in a typical use case. Adding --verbose will still show it, for those who need it.
Fixes #1139
Some questions I have:
EDIT: wrong issue number