Skip to content

Conversation

@nlacasse
Copy link

The id and containers attrs should be lowercase.

Fixes #527

@nlacasse
Copy link
Author

Sorry for not adding tests, but for some reason none of the tests run for me.

They all loop forever with messages like:

2025-08-27 21:08:15 [    INFO] Launching(4.9.3) podman --log-level=info system service --time=0 unix:///tmp/tmpocgy0b6d/498a901d0d504c4e9b302f93e369569c refid=1290867612650871671 (utils.py:86)
2025-08-27 21:08:15 [   DEBUG] Starting new HTTP connection (1): localhost:22 (connectionpool.py:241)
2025-08-27 21:08:15 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:15 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:16 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:16 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:16 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:16 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:16 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
2025-08-27 21:08:17 [   DEBUG] Waiting on /run/user/1000/podman/podman-forward-7e5394932fe630968a58.sock (ssh.py:89)
...

I followed the steps in CONTRIBUTING, so I'm not sure what could be wrong.

@inknos
Copy link
Contributor

inknos commented Sep 2, 2025

if you are able to ssh localhost the error should go away. we should correct the CONTRIBUTING

@inknos
Copy link
Contributor

inknos commented Sep 2, 2025

/packit retest-failed

Copy link
Contributor

@inknos inknos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlacasse thanks for the PR

A couple of points

  • what is the reason of returning "id" instead of "Id"?
  • can we just change "containers" in this PR? let's focus on fixing the tests and have them running consistently on your machine and in this PR, what do you say? :)

@nlacasse
Copy link
Author

nlacasse commented Sep 5, 2025

Thanks! I reverted the Id -> id change. I think something weird is still going on there, but I'll investigate further and open a separate PR if needed.

Also the tests are working fine for me now. Not sure what was going on before. Sorry for the noise.

@nlacasse
Copy link
Author

nlacasse commented Sep 5, 2025

I filed a new bug for the Id issue.

@inknos
Copy link
Contributor

inknos commented Sep 8, 2025

Also the tests are working fine for me now. Not sure what was going on before.

tests were off because of Id, mostly. I didn't investigate through all of them though

Sorry for the noise.

no problem


@nlacasse checks are green, that's awesome! DCO check is still complaining, but you commit looks well forged and signed. maybe, try to rebase to main and push again?

@nlacasse nlacasse force-pushed the network-attrs branch 2 times, most recently from 40f1771 to 35d7a8a Compare September 8, 2025 20:14
Fixes containers#527

Signed-off-by: Nicolas Lacasse <nicolas.lacasse@gmail.com>
@nlacasse
Copy link
Author

nlacasse commented Sep 8, 2025

@nlacasse checks are green, that's awesome! DCO check is still complaining, but you commit looks well forged and signed. maybe, try to rebase to main and push again?

Done. DCO seems happy now.

@inknos
Copy link
Contributor

inknos commented Sep 9, 2025

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, nlacasse

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 9, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 512dd42 into containers:main Sep 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect key used in the Network.containers property

2 participants