-
Notifications
You must be signed in to change notification settings - Fork 124
Fix attr getters in Network Resource #576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
242b37e to
425fd96
Compare
|
Sorry for not adding tests, but for some reason none of the tests run for me. They all loop forever with messages like: I followed the steps in |
|
if you are able to |
|
/packit retest-failed |
425fd96 to
d26c923
Compare
inknos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nlacasse thanks for the PR
A couple of points
- what is the reason of returning "id" instead of "Id"?
- can we just change "containers" in this PR? let's focus on fixing the tests and have them running consistently on your machine and in this PR, what do you say? :)
d26c923 to
b4483b8
Compare
|
Thanks! I reverted the Also the tests are working fine for me now. Not sure what was going on before. Sorry for the noise. |
|
I filed a new bug for the |
tests were off because of Id, mostly. I didn't investigate through all of them though
no problem @nlacasse checks are green, that's awesome! DCO check is still complaining, but you commit looks well forged and signed. maybe, try to rebase to main and push again? |
40f1771 to
35d7a8a
Compare
Fixes containers#527 Signed-off-by: Nicolas Lacasse <nicolas.lacasse@gmail.com>
35d7a8a to
0f7d250
Compare
Done. DCO seems happy now. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, nlacasse The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
idandcontainersattrs should be lowercase.Fixes #527