Add direct support to --manifest when building container images.

[MisterOwlPT]

Closes #592.

With the proposed changes it is now possible to create manifests and automatically add images to them as part of the build process (equivalent to podman build --manifest ...).

# ...
with PodmanClient(base_url=uri) as client:
  image, _ = client.images.build(
    path=".",
    dockerfile="Containerfile",
    manifest="example:v1.2.3",  # <-- this field is now supported 
    platform=["linux/amd64", "linux/arm64"],
  )

Running the previous code, all built images are automatically added to the provided manifest (which is also created if it does not exist already).

Changes:

• Mapped the --manifest argument into the expected manifest query parameter when making requests;
• Updated documentation for the client.images.build function as to refer to the newly support field. Description text extracted from the Podman CLI itself;
• Updated existing unit tests to ensure that --manifest argument is mapped into the expected query parameter;
• Implemented new integration test to ensure that a manifest is automatically created if required. A complementary cleanup mechanism was also implemented to ensure that manifests created during tests are deleted after their execution.

Looking forward to your feedback.

[jwhonce]

/approve

LGTM

[MisterOwlPT]

Hi @jwhonce,

Some more points concerning this PR.

• I have fixed the existing linting errors;
• I've shortened the two long commit messages (to fit the 72 character limit).
• Removed accidental signature lines from commits I didn’t author and only the commits that are actually mine are now signed by me.

Thanks for the review, and really really sorry for the extra noise!

Edit: typos

[jwhonce]

@MisterOwlPT It appears the commit linter is still not happy with your work.

[MisterOwlPT]

@jwhonce,
I've amended the troublesome commit messages.
Everything should be fine now.

Let me know if everything looks good to you.

[inknos]

@MisterOwlPT your code is clean and linter is happy, nice job.

I believe you need to rebase to main and fix the commits, I see the commit history is mixed with merged history, that's not clean and can't be merged.

I tried to rebase locally, and this is what imho looks nicer in a single patch. what do you think?

0001-support-flag-manifest-when-building-container-images.patch

[MisterOwlPT]

@inknos,

I believe you need to rebase to main and fix the commits, I see the commit history is mixed with merged history, that's not clean and can't be merged.

Yes, sincere apologies for that!
As suggested, I've git rebase to main and fixed the commits.
I believe this branch is now clean as intended.

Let me know if something else is required.
Thanks once again for your patience!

[inknos]

great job with the commits, I found a thing that could break the expected behavior, please take a look and let me know

[inknos]

@MisterOwlPT all is good. let me just nitpick on the commits. we don't squash on merge, and the change looks nice on a single commit since it's all part of one added feature. would you do squash them, please? then I'll merge :D

[MisterOwlPT]

@inknos,

would you do squash them, please?

Done!
I got a bit carried away with "little, incremental commits" 😅

[Honny1]

At first glance, the code LGTM. Let's see what CI has to say.

Edit: approved CI passed

[inknos]

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inknos, jwhonce, MisterOwlPT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inknos,jwhonce]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment