cgroup: change cgroup deletion logic on v1#9464
Merged
openshift-merge-robot merged 1 commit intocontainers:masterfrom Feb 22, 2021
Merged
cgroup: change cgroup deletion logic on v1#9464openshift-merge-robot merged 1 commit intocontainers:masterfrom
openshift-merge-robot merged 1 commit intocontainers:masterfrom
Conversation
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
rhatdan
reviewed
Feb 22, 2021
do not raise an error if the cgroup exists at least on one controller. Previously it expected the cgroup to exists under all the controllers. [NO TESTS NEEDED] Closes: containers#9252 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
fix-cgroupv1-stats
branch
from
a44c421 to
e87c5b6
Compare
Member
|
LGTM |
Member
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do not raise an error if the cgroup exists at least on one
controller.
Previously it expected the cgroup to exists under all the
controllers.
[NO TESTS NEEDED]
Closes: #9252
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com