[NO TESTS NEEDED] Shrink the size of podman bindings by rhatdan · Pull Request #9516 · containers/podman

rhatdan · 2021-02-25T13:49:13Z

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

openshift-ci-robot · 2021-02-25T13:49:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TomSweeneyRedHat · 2021-03-08T15:46:47Z

@rhatdan needs a rebase

rhatdan · 2021-03-12T11:20:10Z

@cevich Still getting the same errors, I don't believe the VM was updated.

cevich · 2021-03-15T13:07:05Z

FWIW this error is all over the F33 logs, in nearly/every test:

time="2021-03-13T11:19:02Z" level=warning msg="Error updating pod 2b8...3f4 conmon cgroup PID limit: open /sys/fs/cgroup/libpod_parent/2b8...3f4/conmon/pids.max: no such file or directory"```

rhatdan · 2021-03-16T10:01:14Z

@giuseppe PTAL, would this be causing all of the failures?

giuseppe · 2021-03-16T11:24:11Z

time="2021-03-13T11:19:02Z" level=warning msg="Error updating pod 2b8...3f4 conmon cgroup PID limit: open /sys/fs/cgroup/libpod_parent/2b8...3f4/conmon/pids.max: no such file or directory"```

I don't think so, it is just a warning when we cannot set the cgroup limits for conmon

rhatdan · 2021-03-27T09:30:26Z

@containers/podman-maintainers This one is ready to merge PTAL

TomSweeneyRedHat · 2021-03-27T17:50:15Z

libpod/runtime_img.go

Is github.com/containers/podman/v3/libpod/define going away eventually? If not, rather than buildah here and just define elsewhere, I think this should be bdefine or something that's easily identified as being different than Podman's define.

I concur with Tom. I would prefer to alias all imports of this package as buildahDefine. My eyes are used to read define as the Podman package.

I am waiting for my other pull-never gets merged, before fixing this, in case of conflicts.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

rhatdan · 2021-03-29T14:06:36Z

Ok they are all buildahDefine now.

vrothberg

LGTM

baude · 2021-03-29T17:13:29Z

/lgtm

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2021

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2021

rhatdan force-pushed the shrink branch 2 times, most recently from caf504b to ccb2018 Compare February 25, 2021 18:25

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021

rhatdan force-pushed the shrink branch from ccb2018 to 1ff15fe Compare February 25, 2021 18:28

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2021

rhatdan force-pushed the shrink branch 4 times, most recently from 3800cc2 to 159357c Compare February 25, 2021 21:48

rhatdan mentioned this pull request Feb 27, 2021

Vendor in containers/common and start using types subdir. containers/common#466

Merged

rhatdan force-pushed the shrink branch 3 times, most recently from 4be3f79 to e215284 Compare March 4, 2021 19:14

rhatdan changed the title ~~[WIP] [NO TESTS NEEDED] Shrink the size of podman bindings~~ [NO TESTS NEEDED] Shrink the size of podman bindings Mar 4, 2021

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2021

rhatdan force-pushed the shrink branch from e215284 to dd95d27 Compare March 5, 2021 20:12

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2021

rhatdan force-pushed the shrink branch from dd95d27 to 1f0015d Compare March 8, 2021 11:19

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021

rhatdan force-pushed the shrink branch from 1f0015d to 3eb9a79 Compare March 8, 2021 11:26

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021

rhatdan force-pushed the shrink branch from 3eb9a79 to af88d63 Compare March 8, 2021 17:02

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021

rhatdan force-pushed the shrink branch 3 times, most recently from 5c2c434 to f1be4e4 Compare March 11, 2021 11:19

rhatdan force-pushed the shrink branch from f1be4e4 to 7b7e539 Compare March 12, 2021 10:12

rhatdan force-pushed the shrink branch from 7b7e539 to 3e57905 Compare March 13, 2021 10:47

rhatdan force-pushed the shrink branch 4 times, most recently from 2c137ba to 35c934c Compare March 20, 2021 12:30

rhatdan force-pushed the shrink branch 5 times, most recently from a8592c5 to 566a0cf Compare March 27, 2021 02:04

TomSweeneyRedHat reviewed Mar 27, 2021

View reviewed changes

[NO TESTS NEEDED] Shrink the size of podman-remote

1274008

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

rhatdan force-pushed the shrink branch from 566a0cf to 1274008 Compare March 29, 2021 13:51

vrothberg reviewed Mar 29, 2021

View reviewed changes

openshift-ci-robot assigned baude Mar 29, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021

openshift-merge-robot merged commit 26b0ebd into containers:master Mar 29, 2021

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 23, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 23, 2023

Conversation

rhatdan commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

TomSweeneyRedHat commented Mar 8, 2021

Uh oh!

rhatdan commented Mar 12, 2021

Uh oh!

cevich commented Mar 15, 2021

Uh oh!

rhatdan commented Mar 16, 2021

Uh oh!

giuseppe commented Mar 16, 2021

Uh oh!

rhatdan commented Mar 27, 2021

Uh oh!

TomSweeneyRedHat Mar 27, 2021

Choose a reason for hiding this comment

Uh oh!

vrothberg Mar 29, 2021

Choose a reason for hiding this comment

Uh oh!

rhatdan Mar 29, 2021

Choose a reason for hiding this comment

Uh oh!

rhatdan Mar 29, 2021

Choose a reason for hiding this comment

Uh oh!

rhatdan commented Mar 29, 2021

Uh oh!

vrothberg left a comment

Choose a reason for hiding this comment

Uh oh!

baude commented Mar 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants