Add pod pause/unpause #1126

haircommander · 2018-07-20T19:22:56Z

Added Pause() and Unpause() to libpod/pod.go

Added man pages, tests and completions

Signed-off-by: haircommander pehunt@redhat.com

rh-atomic-bot · 2018-07-21T17:53:54Z

📌 Commit 35d536c has been approved by baude

rh-atomic-bot · 2018-07-21T17:53:59Z

⌛ Testing commit 35d536c with merge 743350a...

Added Pause() and Unpause() to libpod/pod.go Added man pages, tests and completions Signed-off-by: haircommander <pehunt@redhat.com> Closes: #1126 Approved by: baude

baude · 2018-07-21T17:55:01Z

bot, retest this please

rh-atomic-bot · 2018-07-21T17:55:17Z

💡 This pull request was already approved, no need to approve it again.

This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.

rh-atomic-bot · 2018-07-21T17:55:17Z

📌 Commit 35d536c has been approved by baude

rh-atomic-bot · 2018-07-21T18:40:26Z

💔 Test failed - status-papr

rhatdan · 2018-07-22T10:16:04Z

cmd/podman/pod_pause.go

No need for else

rhatdan · 2018-07-22T10:16:53Z

cmd/podman/pod_unpause.go

No need for else.

rhatdan · 2018-07-22T10:18:27Z

docs/podman-pod.1.md

Alphabetize

mheon · 2018-07-22T13:09:14Z

cmd/podman/pod_unpause.go

The logic here is wrong - err will always be set if there's an error, even if ctr_errs is not nil

mheon · 2018-07-22T13:09:37Z

cmd/podman/pod.go

Alphabetize

mheon · 2018-07-24T19:52:03Z

LGTM
@rhatdan @TomSweeneyRedHat @umohnani8 PTAL

TomSweeneyRedHat · 2018-07-24T22:09:24Z

All kinds of test unhappiness, including travis @haircommander

TomSweeneyRedHat · 2018-07-24T23:06:23Z

cmd/podman/pod_unpause.go

Can you pause a running pod? Should this be "unpause all paused pods"?

TomSweeneyRedHat · 2018-07-24T23:07:44Z

cmd/podman/pod_unpause.go

Could be Name or ID no? I think we've other usage's that show you could do one or the other, emulate those.

TomSweeneyRedHat · 2018-07-24T23:08:05Z

cmd/podman/pod_pause.go

Name or ID no?

TomSweeneyRedHat · 2018-07-24T23:36:56Z

Couple nit things.
Education question for me. is there a Pod state? If so, if we have containers in the pod that are paused and others that are started in the pod, what is the Pod state?

mheon · 2018-07-24T23:55:24Z

@TomSweeneyRedHat We don't really have a solid pod state - we display one in ps but generally speaking it's just based on the states its containers are in. I think we would consider a pod Running in your given scenario, given that not all containers are paused?

haircommander · 2018-07-25T13:57:27Z

@TomSweeneyRedHat Yeah, there's documentation on what container state constitutes what pod state in the pod ps man page. @mheon is correct in your scenario, if there are any running containers the pod is considered running.

mheon · 2018-07-25T15:02:27Z

Should be good to merge once travis goes green

TomSweeneyRedHat · 2018-07-25T15:21:09Z

Travis isn't hip @haircommander

rh-atomic-bot · 2018-07-25T18:23:24Z

☔ The latest upstream changes (presumably 8ce0e0b) made this pull request unmergeable. Please resolve the merge conflicts.

mheon · 2018-07-25T19:15:44Z

@haircommander Can you squash the commits down?

haircommander · 2018-07-25T19:19:15Z

yeah I'm trying to figure out how without having to redo the merge again.

mheon · 2018-07-25T19:24:52Z

@haircommander git rebase -i HEAD~3 and fixup the merge commits so they squash

haircommander · 2018-07-25T20:49:15Z

There's some issue with the ginkgo suite and this code. It just stalls after finishing. I reproduce locally and am trying to figure out what is making it happen.

mheon · 2018-07-26T19:01:58Z

@haircommander Can you rebase against master to fix the tests?

rh-atomic-bot · 2018-07-27T02:49:24Z

☔ The latest upstream changes (presumably f9152d0) made this pull request unmergeable. Please resolve the merge conflicts.

rhatdan · 2018-07-27T11:25:13Z

@haircommander Needs a rebase.

Added Pause() and Unpause() to libpod/pod.go Added man pages, tests and completions Signed-off-by: haircommander <pehunt@redhat.com>

mheon · 2018-07-27T14:13:14Z

I think this is the last thing I'd like in for today's release.

rhatdan · 2018-07-27T14:20:00Z

@rh-atomic-bot r+

rh-atomic-bot · 2018-07-27T14:20:01Z

📌 Commit f9b853d has been approved by rhatdan

rh-atomic-bot · 2018-07-27T14:20:13Z

⌛ Testing commit f9b853d with merge f258e43...

rh-atomic-bot · 2018-07-27T14:51:48Z

☀️ Test successful - status-papr
Approved by: rhatdan
Pushing f258e43 to master...

rh-atomic-bot pushed a commit that referenced this pull request Jul 21, 2018

Add pod pause/unpause

743350a

Added Pause() and Unpause() to libpod/pod.go Added man pages, tests and completions Signed-off-by: haircommander <pehunt@redhat.com> Closes: #1126 Approved by: baude

rhatdan reviewed Jul 22, 2018

View reviewed changes

mheon reviewed Jul 22, 2018

View reviewed changes

cmd/podman/pod_unpause.go Outdated

Copy link

Member

mheon Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is wrong - err will always be set if there's an error, even if ctr_errs is not nil

mheon reviewed Jul 22, 2018

View reviewed changes

cmd/podman/pod.go Outdated

Copy link

Member

mheon Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetize

haircommander force-pushed the pod-pause-unpause branch 4 times, most recently from d4d6b5b to e40ae0a Compare July 24, 2018 18:22

TomSweeneyRedHat reviewed Jul 24, 2018

View reviewed changes

cmd/podman/pod_unpause.go Outdated

Copy link

Member

TomSweeneyRedHat Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pause a running pod? Should this be "unpause all paused pods"?

TomSweeneyRedHat reviewed Jul 24, 2018

View reviewed changes

cmd/podman/pod_pause.go Outdated

Copy link

Member

TomSweeneyRedHat Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name or ID no?

haircommander force-pushed the pod-pause-unpause branch from e40ae0a to 46d9f9e Compare July 25, 2018 14:02

haircommander force-pushed the pod-pause-unpause branch from 1926861 to c1eb681 Compare July 25, 2018 19:25

haircommander force-pushed the pod-pause-unpause branch from c1eb681 to dc64694 Compare July 26, 2018 14:19

haircommander force-pushed the pod-pause-unpause branch from dc64694 to 1478c18 Compare July 26, 2018 20:16

Add pod pause/unpause

f9b853d

Added Pause() and Unpause() to libpod/pod.go Added man pages, tests and completions Signed-off-by: haircommander <pehunt@redhat.com>

haircommander force-pushed the pod-pause-unpause branch from 1478c18 to f9b853d Compare July 27, 2018 13:56

rh-atomic-bot closed this in f258e43 Jul 27, 2018

elimisteve mentioned this pull request Jul 27, 2018

Running containers inside of a container environment (with docker-compose.yml) using podman? #746

Closed

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023

Add pod pause/unpause #1126

Add pod pause/unpause #1126

Uh oh!

Conversation

haircommander commented Jul 20, 2018

Uh oh!

rh-atomic-bot commented Jul 21, 2018

Uh oh!

rh-atomic-bot commented Jul 21, 2018

Uh oh!

baude commented Jul 21, 2018

Uh oh!

rh-atomic-bot commented Jul 21, 2018

Uh oh!

rh-atomic-bot commented Jul 21, 2018

Uh oh!

rh-atomic-bot commented Jul 21, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mheon commented Jul 24, 2018

Uh oh!

TomSweeneyRedHat commented Jul 24, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat commented Jul 24, 2018

Uh oh!

mheon commented Jul 24, 2018

Uh oh!

haircommander commented Jul 25, 2018

Uh oh!

mheon commented Jul 25, 2018

Uh oh!

TomSweeneyRedHat commented Jul 25, 2018

Uh oh!

rh-atomic-bot commented Jul 25, 2018

Uh oh!

mheon commented Jul 25, 2018

Uh oh!

haircommander commented Jul 25, 2018

Uh oh!

mheon commented Jul 25, 2018

Uh oh!

haircommander commented Jul 25, 2018

Uh oh!

mheon commented Jul 26, 2018

Uh oh!

rh-atomic-bot commented Jul 27, 2018

Uh oh!

rhatdan commented Jul 27, 2018

Uh oh!

mheon commented Jul 27, 2018

Uh oh!

rhatdan commented Jul 27, 2018

Uh oh!

rh-atomic-bot commented Jul 27, 2018

Uh oh!

rh-atomic-bot commented Jul 27, 2018

Uh oh!

rh-atomic-bot commented Jul 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development