quadlet kube: correctly mark unit as failed #25481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very bad practise to print to stdout in our backend code without nay real context. The exact same error message is returned to the caller and printed in the cli frontend hwere it should be. Therefore drop this print as it is redundant. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The first condition is checking an error where no error is returned and the second is checking even though err == nil was matched above already so we know the error is not nil here. Then also replace os.IsNotExist(err) with errors.Is(err, os.ErrNotExist) as that should be used for new code. This should not change behavior in any way. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Luap99
force-pushed
the
kube-sdnotify-error
branch
from
68c31df to
bacab64
Compare
When no containers could be started we need to make sure the unit status reflects this. This means we should not send the READ=1 message and not keep the service container running when we were unable to start any container. There is the question what should happen when only a subset was started. For systemd we can only be either running or failed. And as podman kube play also just keeps the partial started pods running I opted to let systemd keep considering this as success. Fixes containers#20667 Fixes https://issues.redhat.com/browse/RHEL-80471 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
kube-sdnotify-error
branch
from
bacab64 to
945aade
Compare
Member
|
/lgtm |
ygalblum
reviewed
Mar 5, 2025
| setRanContainers := func(r *entities.PlayKubeReport) { | ||
| if !ranContainers { | ||
| for _, p := range r.Pods { | ||
| // If the list of container errors is less then the total number of pod containers then we know it didn't start. |
Contributor
There was a problem hiding this comment.
Should the comment be that it did start?
Member
Author
There was a problem hiding this comment.
oh yes, I guess I just sneak it in my next PR as small typo fix commit.
openshift-merge-bot
bot
merged commit 919247a
into
containers:main
65 of 82 checks passed
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Mar 13, 2025
It did start there, as pointed out by Ygal on containers#25481. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no containers could be started we need to make sure the unit status
reflects this. This means we should not send the READ=1 message and not
keep the service container running when we were unable to start any
container.
There is the question what should happen when only a subset was started.
For systemd we can only be either running or failed. And as podman kube
play also just keeps the partial started pods running I opted to let
systemd keep considering this as success.
Fixes #20667
Fixes https://issues.redhat.com/browse/RHEL-80471
And two more minor fixes, see the first two commits
Does this PR introduce a user-facing change?