-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add release notes for Podman v5.6.0-rc1 #26688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release notes for Podman v5.6.0-rc1 #26688
Conversation
RELEASE_NOTES.md
Outdated
| - When creating `podman machine` VMs on Windows using the WSL v2 provider, images are now pulled as artifacts from `quay.io/podman/machine-os`, matching the behavior of other VM providers. | ||
| - Signal forwarding done by the `--sig-proxy` option to `podman run` and `podman attach` is now more robust to races and no longer forwards the `SIGSTOP` signal. | ||
| - The `podman system check --quick` command now skips checking layer digests. | ||
| - Containers in networks with DNS enabled via `aardvark-dns` now append include the host's search domains in `/etc/resolv.conf` ([#24713](https://github.com/containers/podman/issues/24713)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we already fix this in v5.5.1?
- Fixed a bug where containers joined to a network with DNS enabled would not include the host's search domains in their
resolv.conf(#24713).
So this should not be mentioned on 5.6 again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a vote against the new logic for identifying what gets a release note. I'll remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you need a way to check what has been backported and released in a prior patch release already and then skip it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I previously relied on a manual check of commits in the old vs new branches by hash, and then did a further substring check for exact matches of commit subject to try and identify cherry-picks. This time, I switched to git cherry to try and replace both, because the substring bit was inexact and worried me that it'd eliminate real release notes. Evidently I need to look into re-adding the substring check.
Signed-off-by: Matt Heon <mheon@redhat.com>
2b570ce to
e22fc65
Compare
|
Comments addressed & re-pushed |
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@containers/podman-maintainers PTAL and merge |
lsm5
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
testing-farm rawhide failed on subids, so I guess we gotta get testing-farm to build new images once the shadow utils change is reverted. |
4414b24
into
containers:v5.6
As the title says
Does this PR introduce a user-facing change?