-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: introduce custom version selector in api.html #27295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: introduce custom version selector in api.html #27295
Conversation
Signed-off-by: Martin Fischer <martin@push-f.com>
Preparation for the next commit in which we'll make the script tag async (in order to use await to fetch the new versions.json file). Signed-off-by: Martin Fischer <martin@push-f.com>
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to build and display the changes, and I got a syntax error. You can find instructions on how to build the documentation locally here.
dd42742
to
db60b7d
Compare
Ah yeah sorry. I did build it locally but getting the specs from storage.googleapis.com fails locally because of CORS, so I had to use a relative URL and when I changed it back I introduced the syntax error. Fixed! |
LGTM |
db60b7d
to
4cd4be1
Compare
(Slightly corrected a comment: clearing the redoc-container led to errors rather than the delay.) |
4cd4be1
to
867bc3c
Compare
Fixes: containers#27277 Signed-off-by: Martin Fischer <martin@push-f.com>
867bc3c
to
f87c8b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ashley-cui Mind doing final review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, flouthoc, Honny1, not-my-profile The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #27277.
Does this PR introduce a user-facing change?