-
Notifications
You must be signed in to change notification settings - Fork 2.9k
new vm image sfx for fedora 43 base image update #27514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
new vm image sfx for fedora 43 base image update #27514
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timcoding1988 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
26f0a45 to
1c9d3f9
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
3 similar comments
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
9040a15 to
61ff57c
Compare
https://api.cirrus-ci.com/v1/artifact/task/6535796057964544/html/apiv2-podman-fedora-43-root-host.log.html |
|
@Luap99 1. https://docs.fedoraproject.org/en-US/fedora/latest/release-notes/developers/#python-3-14 related to fedora 43. also i did make change on automation_images duo to failure log. |
has to be python3.13, taking a look edit: oh wow, 3.14, wasn't expecting it |
|
From
which leads us to this It's likely to be easy to reproduce and fix locally. I can try |
|
For Easy things would be to unset the env in CI setup which is likely want we want to do anyway as it affects many other things but still I am not sure why this specific test would care about it. The other failure I think this is the same thing have been seeing in the podman-machine-os CI, the main point here is that this testing on tmpdir root Nov 13 13:43:18 ip-172-31-27-118.ec2.internal audit[45020]: AVC avc: denied { read } for pid=45020 comm="top" path="/bin/busybox" dev="tmpfs" ino=9753 scontext=system_u:system_r:container_t:s0:c28,c816 tcontext=system_u:object_r:container_var_run_t:s0 tclass=file permissive=0 cc @lsm5 |
diff --git a/test/apiv2/python/rest_api/test_v2_0_0_image.py b/test/apiv2/python/rest_api/test_v2_0_0_image.py
index e62b210ebc..8c354c67ab 100644
--- a/test/apiv2/python/rest_api/test_v2_0_0_image.py
+++ b/test/apiv2/python/rest_api/test_v2_0_0_image.py
@@ -1,6 +1,6 @@
import json
import unittest
-from multiprocessing import Process
+from multiprocessing import Process, set_start_method
import requests
from dateutil.parser import parse
@@ -168,6 +168,9 @@ class ImageTestCase(APITestCase):
self.assertEqual(r.status_code, 400, f"#5: {r.text}")
i = 1
+ # Need to explicitely set start method
+ # https://docs.python.org/dev/library/multiprocessing.html#contexts-and-start-methods
+ set_start_method('fork')
for fn in [do_search1, do_search2, do_search3, do_search4, do_search5]:
with self.subTest(i=i):
search = Process(target=fn)this fixed the python error for me. I am forcing the spawn method to |
Ok I had a lock and it seems buildah leaks the NOTIFY_SOCKET env into crun and crun then forwards that socket into the container? And as such it creates the inodes on the rootfs thus making them appear in the final image that the test diffs. @timcoding1988 So in this case we should indeed make sure NOTIFY_SOCKET is unset as part of the cirrus CI setup scripts as it could interact weirdly with other tests as well. |
yes that is expected as the container payload will use
and I think this is the correct thing to do, if you are not using the systemd notify API, there is no reason to pass the env variable |
Signed-off-by: Tim Zhou <tizhou@redhat.com>
09e99ed to
a51bde0
Compare
new vm image sfx for fedora 43 base image update -> containers/automation_images#426
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?