-
Notifications
You must be signed in to change notification settings - Fork 2.9k
update fedoral base image to 43 and related tests #27581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update fedoral base image to 43 and related tests #27581
Conversation
Signed-off-by: Tim Zhou <tizhou@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timcoding1988 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The code change looks OK, but the failed tests on F43 look like something which need to be fixed before merging. The F42 tests pass and I also checked that the F43 test failures are specific to this PR - they do not appear on other PRs. |
|
I think the the place where you |
Unsetting it in the test is not right though. If the env has a leaked NOTIFY_SOCKET it must be unset for all tests as this will affect most commands which can lead to weird failures like this. We need to understand where (and why) it gets sets all of the sudden set and ensure it is unset before running the tests. |
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
dd5360c to
f768705
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
6 similar comments
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
update fedoral base image to 43 and related tests.
original PR
automation image pr: containers/automation_images#426
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?