-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(info): expose default network name #27608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(info): expose default network name #27608
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kyounghunJang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Honny1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, could you please remove the vendoring commit from this PR? If this requires a bump of common, I would suggest doing it in a separate PR.
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you need to reorder your commits, the vendor commit should be first otherwise you break the build.
Also please squash the lint commit into the right commit, we don't want fixup commits on PRs as we merge commits as is.
Eh, we do vendoring all the time in the same PR with other changes, as long as you do it in separate commits that is fine. |
I got confused by the failed build. I didn't realize strict ordering was the issue. That's why I thought a separate PR was needed. |
|
#27612 did the vendoring for another feature so you can drop the vendor here and just add the podman test |
Fixes containers#27580 Signed-off-by: Kyounghoon Jang <matkimchi_@naver.com>
da91463 to
266ba5a
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Description
This PR exposes the default network name in
podman infooutput undernetworkBackendInfo.Currently, the default network is usually
podman, but users can customize this incontainers.conf. Downstream tools (like Podman Desktop) and users need a way to programmatically determine what the current default network name is.Fixes #27580
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?