Skip to content

Conversation

@nimdrak
Copy link
Contributor

@nimdrak nimdrak commented Nov 26, 2025

…mission

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

cc. @Honny1

…due to permission

Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nimdrak
Once this PR has been reviewed and has the lgtm label, please assign nalind for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nimdrak nimdrak changed the title [WIP] Fixes #27184: Enhance error logs when it failed to relabel due to permission [WIP] Enhance error logs when it failed to relabel due to permission Nov 26, 2025
@nimdrak
Copy link
Contributor Author

nimdrak commented Nov 26, 2025

After adding a unit test for the change, I will make this ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant