Skip to content

make sure hooks are renamed for copr spec #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2018
Merged

make sure hooks are renamed for copr spec #797

merged 1 commit into from
May 17, 2018

Conversation

@baude
Copy link
Member

@baude baude commented May 17, 2018

Signed-off-by: baude bbaude@redhat.com

@baude
make sure hooks are renamed for copr spec
ca528d8 
Signed-off-by: baude <bbaude@redhat.com>
@baude baude merged commit 4704c13 into containers:master May 17, 2018
wking
wking reviewed May 17, 2018
View reviewed changes
contrib/spec/podman.spec.in
%prep
%autosetup -Sgit -n podman-%{shortcommit}
sed -i '/\/bin\/env/d' completions/bash/%{name}
mv pkg/hooks/README.md pkg/hooks/README-hooks.md
Copy link
Contributor

@wking wking May 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd removed this in #772, which moved all critical information from pkg/hooks/README.md into oci-hooks.5, which should be installed via this and this. Does that not work for some reason?

Copy link
Contributor

@wking wking May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On IRC, @baude pointed out the presence of an exising consumer. LooksI'd missed like a sloppy rebase on my part, and I've filed #801 to remove both this mv and the missed consumer.

@baude baude deleted the coprhooks2 branch December 22, 2019 18:47
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wking wking wking left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baude @wking