podman create, start, getattachsocket #805
Conversation
pkg/varlinkapi/containers_create.go
Outdated
There was a problem hiding this comment.
We should move all these into createConfig.GetContainerCreateOptions() so we can share code between this, run, and create
There was a problem hiding this comment.
can we defer that to another PR; given the huge change, i really wanted to achieve getting this working first.
pkg/varlinkapi/containers.go
Outdated
pkg/varlinkapi/containers.go
Outdated
There was a problem hiding this comment.
Instead of making BundlePath public, it would probably be better to have a ctr.ControlSocketPath() that returns this
|
☔ The latest upstream changes (presumably #809) made this pull request unmergeable. Please resolve the merge conflicts. |
baude
force-pushed
the
varlinkstart
branch
3 times, most recently
from
66f5c3c to
08acf68
Compare
First pass at implement API endpoints for create and start. Signed-off-by: baude <bbaude@redhat.com>
|
I'm going to LGTM this, but we really need to do refactoring work to clean this up soon - we now have duplicated some of the create code in three places. |
|
📌 Commit f676606 has been approved by |
|
☀️ Test successful - status-papr |
github-actions
bot
added
the
locked - please file new issue/PR
3 participants
First pass at implement API endpoints for create and start.
Signed-off-by: baude bbaude@redhat.com