Skip to content

Conversation

@wking
Copy link
Contributor

@wking wking commented May 20, 2018

We've had this functionality since #686, but didn't have any user-facing docs for it. And Podman/libpod doesn't use this yet, but CRI-O will if/when cri-o/cri-o#1517 lands.

We've had this functionality since 68eb128 (pkg/hooks: Version the
hook structure and add 1.0.0 hooks, 2018-04-27, containers#686), but didn't have
any user-facing docs for it.

Signed-off-by: W. Trevor King <wking@tremily.us>
@wking wking force-pushed the document-hook-precedence branch from 66d0a62 to d35ae22 Compare May 20, 2018 00:08
Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented May 21, 2018

LGTM
@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit d35ae22 has been approved by mheon

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit d35ae22 with merge fb62838...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: mheon
Pushing fb62838 to master...

@wking wking deleted the document-hook-precedence branch May 21, 2018 16:36
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants