Fix URL encode resource's id before calling API endpoints

[andsarr]

What does this PR do?

This PR fix the 404 error when a router's name contains the character /.

From the UI, when the user clicks in the table, the router's name is encoded before calling the API. In the backend, the URL path parameter is decoded before the look up.

Motivation

Fixes 10177

More

• Added/updated tests
• Added/updated documentation

Additional Notes

Should I also decode the URL path parameter for the other API endpoints?

[kevinpollet]

Hello @andsarr, and thank you for your contribution.

We have tested the changes, and everything is working well. We would appreciate it if you could provide fixes for other endpoints (services, middlewares) and all UDP and TCP resources.

Could you please update the pull request to include these changes?

[andsarr]

@kevinpollet sure! I'll do it!

[andsarr]

@kevinpollet now it is ready. Since I am using a middleware for decoding the URL path parameters, I didn't need to change too many files in the backend.

[andsarr]

I don't understand why the unit tests fails in GitHub. If I execute make test-unit in my PC, all the tests are green. I also tried to executing the failing test independently and it was successful.

The weirdest part is that if I run IN_DOCKER= make test-unit then the Open Telemetry test is the one that fails. I'll keep digging.

[ldez]

It's just a flaky test, we relaunched the check.

[rtribotte]

Hello @andsarr,

Thanks for the recent adjustments!

The middleware could have been an elegant solution. Still, since it requires modification of the Vars map in the request context, I would prefer the previous approach to transform the parameter in each handler. Also, it would not hide that we do such a transformation.

The trace log seems unnecessary as it does not provide much information, and in the Traefik code base, we do not use this level. For these reasons, it should be removed.

[rtribotte]

Also, since this PR is a bug fix, can you please rebase it on the v2.10 branch?

[andsarr]

@rtribotte I have implemented all the requested changes. I have run the tests locally and they all passed. I think I am having the same issue as here #10292 (comment)

[andsarr]

Hi all!
Is there something else needed to be done from my side?

[mmatur]

Hi @andsarr,

Nothing to do on your side, maintainers need to review your PR and it will be available in the next Traefik v2.11 version

[rtribotte]

Thanks 👍

[andsarr]

@kevinpollet I have addressed all the comments.

[kevinpollet]

Thanks 👍

[lbenguigui]

LGTM