Skip to content

Support Kubernetes basic-auth secrets#8189

Merged
traefiker merged 7 commits intotraefik:masterfrom
dtomcej:issue-7867
Sep 14, 2021
Merged

Support Kubernetes basic-auth secrets#8189
traefiker merged 7 commits intotraefik:masterfrom
dtomcej:issue-7867

Conversation

@dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Jun 15, 2021

What does this PR do?

Provides support for basic-auth type secrets in the kubernetes basicAuth middleware.

Motivation

Fixes #7867

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • This PR keeps the same behavior for digestAuth, only basic-auth has additional secret format options.
  • This PR takes the SHA1 of the secret to pass to the auth middleware. It really doesn't matter as the secret contains un-encrypted data.

Co-authored-by: Romain rtribotte@users.noreply.github.com

Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

Copy link
Collaborator

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the next milestone Jun 18, 2021
@jbdoumenjou jbdoumenjou modified the milestones: 2.5, next Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K8-Middleware-BasicAuth - doesn't recognize Secret:kubernetes.io/basic-auth:string data

6 participants