Skip to content

fix: run package builds during publish []#10912

Merged
Mitch Goudy (mgoudy91) merged 1 commit into
masterfrom
codex/fix-package-publish-lib
Apr 22, 2026
Merged

fix: run package builds during publish []#10912
Mitch Goudy (mgoudy91) merged 1 commit into
masterfrom
codex/fix-package-publish-lib

Conversation

@mgoudy91
Copy link
Copy Markdown
Contributor

Summary

Prevents malformed package releases by ensuring publish-time build scripts run when Lerna publishes tagged packages from CI.

Changes

  • override ignore-scripts during the CircleCI package publish step so package lifecycle build scripts can run
  • switch publishable packages to prepack so packaging itself produces lib/dist before publish
  • cover the packages currently relying on generated publish artifacts: @contentful/ecommerce-app-base, @contentful/dam-app-base, and @contentful/eslint-plugin-contentful-apps

Notes

  • This follows the @contentful/ecommerce-app-base@4.1.0 release, which produced a package without lib/ even though the GitHub release/tag existed.
  • Verified locally by running NPM_CONFIG_IGNORE_SCRIPTS=false npm pack --dry-run --json in packages/ecommerce-app-base from a clean directory and confirming the tarball contains lib/index.js.

Updated in:

  • .circleci/config.yml
  • packages/ecommerce-app-base
  • packages/dam-app-base
  • packages/eslint-plugin-contentful-apps

@mgoudy91 Mitch Goudy (mgoudy91) marked this pull request as ready for review April 22, 2026 18:51
@mgoudy91 Mitch Goudy (mgoudy91) requested review from a team as code owners April 22, 2026 18:51
@mgoudy91 Mitch Goudy (mgoudy91) merged commit 0efc908 into master Apr 22, 2026
17 checks passed
@mgoudy91 Mitch Goudy (mgoudy91) deleted the codex/fix-package-publish-lib branch April 22, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant