Skip to content

Fix github actions token permissions issue in release.yaml [DX-505] #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Fix github actions token permissions issue in release.yaml [DX-505] #2600

merged 1 commit into from
Nov 14, 2025

Conversation

@ethan-ozelius-contentful
Copy link
Contributor

@ethan-ozelius-contentful ethan-ozelius-contentful commented Nov 13, 2025 •
edited
Loading

Summary

Fix failing release job in this github action, raised in this issue

Description

Error

Run hashicorp/vault-action@v3.4.0
  with:
    url: ***
    role: contentful.js-github-action
    method: jwt
    path: github-actions
    exportEnv: false
    secrets: github/token/contentful.js-semantic-release token | GITHUB_TOKEN;
  
    kubernetesTokenPath: /var/run/secrets/kubernetes.io/serviceaccount/token
    exportToken: false
    outputToken: false
    tlsSkipVerify: false
    jwtTtl: 3600
    ignoreNotFound: false
Get Vault Secrets
Token Info
  

Error: Response code 403 (Forbidden)

@ethan-ozelius-contentful ethan-ozelius-contentful force-pushed the dx-505-fix-semantic-release-again branch 2 times, most recently from 2ce8121 to 649c1b5 Compare November 13, 2025 20:40
@ethan-ozelius-contentful ethan-ozelius-contentful changed the title break build to get github action permission error Fix github actions token permissions issue in release.yaml [DX-505] Nov 13, 2025
@ethan-ozelius-contentful ethan-ozelius-contentful force-pushed the dx-505-fix-semantic-release-again branch 6 times, most recently from d9ae231 to 468e94e Compare November 13, 2025 22:25
ethan-ozelius-contentful
ethan-ozelius-contentful commented Nov 13, 2025
View reviewed changes
package.json
"homepage": "https://www.contentful.com/developers/documentation/content-delivery-api/",
"type": "module",
"exports": {
".": {
Copy link
Contributor Author

@ethan-ozelius-contentful ethan-ozelius-contentful Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just changed the order here, to fix this warning:

The condition "types" here will never be used as it comes after both "import" and "require"

ethan-ozelius-contentful
ethan-ozelius-contentful commented Nov 13, 2025
View reviewed changes
.github/workflows/release.yaml
dist
key: build-cache-${{ github.run_id }}-${{ github.run_attempt }}

- name: Setup Chrome
Copy link
Contributor Author

@ethan-ozelius-contentful ethan-ozelius-contentful Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this back in because of course we have to run npm run build 47 times before we do anything, with runs npm run postbuild, which runs integration tests 🥇

@ethan-ozelius-contentful ethan-ozelius-contentful force-pushed the dx-505-fix-semantic-release-again branch from 468e94e to d6aa0c0 Compare November 13, 2025 22:41
@ethan-ozelius-contentful ethan-ozelius-contentful marked this pull request as ready for review November 13, 2025 22:41
@ethan-ozelius-contentful ethan-ozelius-contentful requested a review from a team as a code owner November 13, 2025 22:41
@ethan-ozelius-contentful ethan-ozelius-contentful force-pushed the dx-505-fix-semantic-release-again branch 6 times, most recently from 452430b to 1920aa2 Compare November 14, 2025 17:13
@ethan-ozelius-contentful ethan-ozelius-contentful force-pushed the dx-505-fix-semantic-release-again branch from 1920aa2 to 6a054df Compare November 14, 2025 17:22
@ethan-ozelius-contentful ethan-ozelius-contentful merged commit f8d1bbd into master Nov 14, 2025
16 checks passed
@ethan-ozelius-contentful ethan-ozelius-contentful deleted the dx-505-fix-semantic-release-again branch November 14, 2025 17:30
@contentful-automation
Copy link
Contributor

contentful-automation bot commented Nov 14, 2025

🎉 This PR is included in version 11.8.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelphamcf michaelphamcf michaelphamcf approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ethan-ozelius-contentful @michaelphamcf