Skip to content

Fix github actions token permissions issue in release.yaml [DX-505] #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
Merged

Fix github actions token permissions issue in release.yaml [DX-505] #2600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ jobs:
dist
key: build-cache-${{ github.run_id }}-${{ github.run_attempt }}

- name: Setup Chrome
Copy link
Contributor Author

@ethan-ozelius-contentful ethan-ozelius-contentful Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this back in because of course we have to run npm run build 47 times before we do anything, with runs npm run postbuild, which runs integration tests 🥇

uses: browser-actions/setup-chrome@v2
with:
install-chromedriver: true

- name: Run semantic release
run: npm run semantic-release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"type": "module",
"exports": {
".": {
Copy link
Contributor Author

@ethan-ozelius-contentful ethan-ozelius-contentful Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just changed the order here, to fix this warning:

The condition "types" here will never be used as it comes after both "import" and "require"

"types": "./dist/types/index.d.ts",
"import": "./dist/esm/index.js",
"require": "./dist/contentful.cjs",
"types": "./dist/types/index.d.ts"
"require": "./dist/contentful.cjs"
}
},
"main": "./dist/esm/index.js",
Expand Down
Loading