Skip to content

Revert "docs: Add instruction about Angular 6" #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2018
Merged

Revert "docs: Add instruction about Angular 6" #248

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
424a553
Revert "fix: add browser entry point to package.json"
zcei May 18, 2018
e2f3516
Revert "docs: Add instruction about Angular 6 (#244)"
zcei May 18, 2018
dc94c8a
Merge branch 'master' into revert-244-doc/angular6
Khaledgarbaya May 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,40 +82,6 @@ The Contentful Delivery SDK will be accessible via the `contentful` global varia

Check the [releases](https://github.com/contentful/contentful.js/releases) page to know which versions are available.

### Angular 6:
Currently Angular 6 fail to compile with the SDK because it tries to pick the node disribution instead of the browser one, to fix that Make sure to add the following in your `tsconfig.json` file
```js
"paths":{
"contentful": ["./node_modules/contentful/dist/contentful.browser.js"]
}
```
your `tsconfig.json` should look like this

```js
{
"compileOnSave": false,
"compilerOptions": {
"baseUrl": "./",
"outDir": "./dist/out-tsc",
"sourceMap": true,
"declaration": false,
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "es5",
"paths":{
"contentful": ["./node_modules/contentful/dist/contentful.browser.js"] // add this
},
"typeRoots": [
"node_modules/@types"
],
"lib": [
"es2017",
"dom"
]
}
}
```
### Legacy browsers:

This library also comes with a legacy version to support Internet Explorer 11 and other older browsers. It already contains a polyfill for Promises.
Expand Down