fix: bump axios and add shared .npmrc config [DX-422] #2570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| *.dockerignore | ||
|
|
||
| # NPM config | ||
| .npmrc |
Contributor
There was a problem hiding this comment.
hmm, this could be trouble if someone puts one of their npmrc files that has credentials in them. Im not sure what else to do though so more of just a thought.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's a good thought. We do have a shared .npmrc in several of our other public repos (like contentful-migration), so I'm ok making the change here and I think something to just be mindful of.
elylucasctfl
approved these changes
Sep 26, 2025
Contributor
|
🎉 This PR is included in version 11.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses two issues:
.npmrcconfig to add npm as the registry for@contentfulscoped packagesDescription
The
package-lock.jsonfile was already updated to12.2.2for axios, this now explicitly sets it in thepackage.jsonfile. Also adding the.npmrcto ensure that packages are installed from the correct registry.Motivation and Context
Addresses: #2567
Todos
Screenshots (if appropriate):